use the cluster-api operator for tilt installs instead of clusterctl #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 42.10% 42.10%
=======================================
Files 25 25
Lines 1375 1375
=======================================
Hits 579 579
Misses 783 783
Partials 13 13 ☔ View full report in Codecov by Sentry. |
eljohnson92
force-pushed
the
tilt-cluster-api-operator
branch
11 times, most recently
from
5b96f5b to
a918c11
Compare
komer3
reviewed
Mar 28, 2024
|
@Komer I think the operator sets the right labels? |
komer3
reviewed
Mar 29, 2024
eljohnson92
force-pushed
the
tilt-cluster-api-operator
branch
2 times, most recently
from
1fb83f0 to
ad46f52
Compare
komer3
reviewed
Mar 29, 2024
eljohnson92
force-pushed
the
tilt-cluster-api-operator
branch
from
ad46f52 to
c592aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR replaces
clusterctl init ...local_commands in tilt with usage of the cluster-api operator and installs of the resources directly. The main benefit of doing it this way is we can easily stream container logs and see the health of the various parts of the CAPL installation. this otherwise should be a no-op for other workflowsWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: